Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ECMAScript modules #1051

Closed
Tracked by #1026
0x2b3bfa0 opened this issue Jun 8, 2022 · 7 comments
Closed
Tracked by #1026

Migrate to ECMAScript modules #1051

0x2b3bfa0 opened this issue Jun 8, 2022 · 7 comments
Assignees
Labels
blocked Dependent on something else icebox releases Shipping builds technical-debt Refactoring, linting & tidying testing Unit tests & debugging

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Jun 8, 2022

We're using CommonJS modules instead of ECMAScript modules, but most of our dependencies are already using the latter. Let's consider migrating and then transpile our code back to CommonJS when needed, e.g. when using pkg to produce standalone binaries.

Dependents

Related

Blockers

@0x2b3bfa0 0x2b3bfa0 added technical-debt Refactoring, linting & tidying testing Unit tests & debugging releases Shipping builds labels Jun 8, 2022
@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Jun 14, 2022

After several1 hours of research, I've come to the conclusion that the easiest “solution” for #1026 is downgrading dependencies to the latest CJS version available. 🙈 See 484143d..e78bbec for some failed attempts at packaging ESM binaries.

Footnotes

  1. Undisclosed quantity

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Jun 17, 2022

@dacbd
Copy link
Contributor

dacbd commented Sep 9, 2022

@0x2b3bfa0
Copy link
Member Author

@dacbd
Copy link
Contributor

dacbd commented Feb 22, 2023

@0x2b3bfa0 should we keep this around after the latest comments: vercel/pkg#1323 (comment)

This feels like an icebox item to me

@0x2b3bfa0
Copy link
Member Author

Vercel's pkg is no longer relevant after #1051 (comment). I'd consider revisiting this eventually, but icebox is fine for now. 👍🏼

@0x2b3bfa0 0x2b3bfa0 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Dependent on something else icebox releases Shipping builds technical-debt Refactoring, linting & tidying testing Unit tests & debugging
Projects
None yet
Development

No branches or pull requests

2 participants