Skip to content

Commit

Permalink
Fix double .options
Browse files Browse the repository at this point in the history
  • Loading branch information
0x2b3bfa0 authored Sep 28, 2022
1 parent f15442d commit 1a373a4
Show file tree
Hide file tree
Showing 11 changed files with 29 additions and 40 deletions.
1 change: 0 additions & 1 deletion bin/cml/asset/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ exports.builder = (yargs) =>
yargs
.env('CML_ASSET')
.option('options', { default: exports.options, hidden: true })
.options(exports.options)
.options(exports.options);

exports.options = kebabcaseKeys({
Expand Down
2 changes: 1 addition & 1 deletion bin/cml/asset/publish.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe('CML e2e', () => {
Options:
--md Output in markdown format [title || name](url) [boolean]
-t, -t, --title Markdown title [title](url) or ![](url title) [string]
-t, --title Markdown title [title](url) or ![](url title) [string]
--native Uses driver's native capabilities to upload assets instead
of CML's storage; not available on GitHub [boolean]
--rm-watermark Avoid CML watermark. [boolean]
Expand Down
1 change: 0 additions & 1 deletion bin/cml/check/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ exports.builder = (yargs) =>
yargs
.env('CML_CHECK')
.option('options', { default: exports.options, hidden: true })
.options(exports.options)
.options(exports.options);

exports.options = kebabcaseKeys({
Expand Down
14 changes: 6 additions & 8 deletions bin/cml/check/create.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,15 @@ describe('CML e2e', () => {
--help Show help [boolean]
Options:
--commit-sha, --head-sha, --head-sha Commit SHA linked to this comment
--commit-sha, --head-sha Commit SHA linked to this comment
[string] [default: HEAD]
--conclusion Conclusion status of the check
--conclusion Conclusion status of the check
[string] [choices: \\"success\\", \\"failure\\", \\"neutral\\", \\"cancelled\\", \\"skipped\\",
\\"timed_out\\", \\"success\\", \\"failure\\", \\"neutral\\", \\"cancelled\\", \\"skipped\\",
\\"timed_out\\"] [default: \\"success\\"]
--status Status of the check
[string] [choices: \\"queued\\", \\"in_progress\\", \\"completed\\", \\"queued\\",
\\"in_progress\\", \\"completed\\"] [default: \\"completed\\"]
--title Title of the check
[string] [default: \\"CML Report\\"]"
--status Status of the check
[string] [choices: \\"queued\\", \\"in_progress\\", \\"completed\\"] [default:
\\"completed\\"]
--title Title of the check [string] [default: \\"CML Report\\"]"
`);
});
});
1 change: 0 additions & 1 deletion bin/cml/comment/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ exports.builder = (yargs) =>
yargs
.env('CML_COMMENT')
.option('options', { default: exports.options, hidden: true })
.options(exports.options)
.options(exports.options);

exports.options = kebabcaseKeys({
Expand Down
27 changes: 13 additions & 14 deletions bin/cml/comment/create.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,21 @@ describe('Comment integration tests', () => {
--help Show help [boolean]
Options:
--pr Post to an existing PR/MR associated
with the specified commit [boolean]
--commit-sha, --head-sha, --head-sha Commit SHA linked to this comment
--pr Post to an existing PR/MR associated with the
specified commit [boolean]
--commit-sha, --head-sha Commit SHA linked to this comment
[string] [default: \\"HEAD\\"]
--publish Upload any local images found in the
Markdown report [boolean]
--publish-url Self-hosted image server URL
--publish Upload any local images found in the Markdown report
[boolean]
--publish-url Self-hosted image server URL
[string] [default: \\"https://asset.cml.dev\\"]
--watch Watch for changes and automatically
update the comment [boolean]
--native Uses driver's native capabilities to
upload assets instead of CML's storage;
not available on GitHub [boolean]
--rm-watermark Avoid watermark; CML needs a watermark
to be able to distinguish CML comments
from others [boolean]"
--watch Watch for changes and automatically update the
comment [boolean]
--native Uses driver's native capabilities to upload assets
instead of CML's storage; not available on GitHub
[boolean]
--rm-watermark Avoid watermark; CML needs a watermark to be able to
distinguish CML comments from others [boolean]"
`);
});

Expand Down
1 change: 0 additions & 1 deletion bin/cml/pr/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ exports.builder = (yargs) =>
yargs
.env('CML_PR')
.option('options', { default: exports.options, hidden: true })
.options(exports.options)
.options(exports.options);

exports.options = kebabcaseKeys({
Expand Down
1 change: 0 additions & 1 deletion bin/cml/repo/prepare.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ exports.builder = (yargs) =>
yargs
.env('CML_REPO')
.option('options', { default: exports.options, hidden: true })
.options(exports.options)
.options(exports.options);

exports.options = kebabcaseKeys({
Expand Down
1 change: 0 additions & 1 deletion bin/cml/tensorboard/connect.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ exports.builder = (yargs) =>
yargs
.env('CML_TENSORBOARD')
.option('options', { default: exports.options, hidden: true })
.options(exports.options)
.options(exports.options);

exports.options = kebabcaseKeys({
Expand Down
19 changes: 9 additions & 10 deletions bin/cml/tensorboard/connect.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,17 @@ describe('CML e2e', () => {
--help Show help [boolean]
Options:
-c, -c, --credentials TensorBoard credentials as JSON, usually found at
~/.config/tensorboard/credentials/uploader-creds.json
-c, --credentials TensorBoard credentials as JSON, usually found at
~/.config/tensorboard/credentials/uploader-creds.json
[string] [required]
--logdir Directory containing the logs to process [string]
--name Tensorboard experiment title; max 100 characters
--logdir Directory containing the logs to process [string]
--name Tensorboard experiment title; max 100 characters [string]
--description Tensorboard experiment description in Markdown format; max
600 characters [string]
--md Output as markdown [title || name](url) [boolean]
-t, --title Markdown title, if not specified, param name will be used
[string]
--description Tensorboard experiment description in Markdown format;
max 600 characters [string]
--md Output as markdown [title || name](url) [boolean]
-t, -t, --title Markdown title, if not specified, param name will be
used [string]
--rm-watermark Avoid CML watermark [boolean]"
--rm-watermark Avoid CML watermark [boolean]"
`);
});

Expand Down
1 change: 0 additions & 1 deletion bin/cml/workflow/rerun.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ exports.builder = (yargs) =>
yargs
.env('CML_WORKFLOW')
.option('options', { default: exports.options, hidden: true })
.options(exports.options)
.options(exports.options);

exports.options = kebabcaseKeys({
Expand Down

2 comments on commit 1a373a4

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Comment

CML watermark

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Comment

CML watermark

Please sign in to comment.