Use Winston for logging whenever possible and always log to stderr

iterative · Sep 23, 2021 · 0481165 · 0481165
1 parent 46cd351
commit 0481165
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/bin/cml.js b/bin/cml.js
@@ -20,6 +20,7 @@ const configureLogger = (level) => {
         ),
     transports: [
       new winston.transports.Console({
+        stderrLevels: Object.keys(winston.config.npm.levels),
         handleExceptions: true,
         handleRejections: true,
         level

diff --git a/bin/cml/runner.js b/bin/cml/runner.js
@@ -93,14 +93,13 @@ const shutdown = async (opts) => {
     }
   };
 
-  if (error) winston.error(error);
-  console.log(
-    JSON.stringify({
-      level: error ? 'error' : 'info',
-      status: 'terminated',
-      reason
-    })
-  );
+  if (error) {
+    winston.error(error, { reason, status: 'terminated' });
+  } else {
+    winston.info('runner status', { reason, status: 'terminated' });
+  }
+
+  winston.info(`waiting ${RUNNER_DESTROY_DELAY} before exiting...`);
   await sleep(RUNNER_DESTROY_DELAY);
 
   if (cloud) {
@@ -229,7 +228,7 @@ const runLocal = async (opts) => {
 
   const dataHandler = async (data) => {
     const log = await cml.parseRunnerLog({ data });
-    log && winston.info('runner log', log);
+    log && winston.info('runner status', log);
 
     if (log && log.status === 'job_started') {
       RUNNER_JOBS_RUNNING.push({ id: log.job, date: log.date });