Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document comment target flag and provide examples. #415

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Document comment target flag and provide examples. #415

merged 4 commits into from
Dec 22, 2022

Conversation

tasdomas
Copy link
Contributor

@tasdomas tasdomas commented Dec 7, 2022 •
edited
Loading

This also removes reference to the github checkout ref from the starting example.

@shcheklein shcheklein temporarily deployed to cml-dev-d003-comment-ta-nkyrxx December 7, 2022 12:51 Inactive
@github-actions
Copy link

github-actions bot commented Dec 7, 2022 •
edited
Loading

Link Check Report

There were no links to check!

@casperdcl casperdcl self-requested a review December 7, 2022 15:21
@casperdcl casperdcl added documentation Markdown files C: ref Content of /doc/*-reference enhancement New feature or request blocked Dependent on something else C: start Content of /doc/start C: guide Content of /doc/user-guide labels Dec 7, 2022
@casperdcl casperdcl mentioned this pull request Dec 7, 2022
Merged
4 tasks
@jorgeorpinel jorgeorpinel removed the C: guide Content of /doc/user-guide label Dec 9, 2022
@tasdomas tasdomas requested a review from a team December 16, 2022 11:40
0x2b3bfa0
0x2b3bfa0 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me! 😋

@tasdomas
Copy link
Contributor Author

This should be landed after the next cml release

@0x2b3bfa0 0x2b3bfa0 merged commit 29c8c9d into master Dec 22, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the d003-comment-target branch December 22, 2022 15:11
@casperdcl casperdcl mentioned this pull request Jan 4, 2023
Merged
@casperdcl casperdcl mentioned this pull request Jan 26, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@casperdcl casperdcl Awaiting requested review from casperdcl

Assignees

@tasdomas tasdomas

Labels
blocked Dependent on something else C: ref Content of /doc/*-reference C: start Content of /doc/start documentation Markdown files enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tasdomas @0x2b3bfa0 @jorgeorpinel @shcheklein @casperdcl