-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home: add bitbucket #362
home: add bitbucket #362
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Done for everything but the GPU example, which doesn't exist because it's not supported. |
* Update example repositories * Fix some broken links * Fix more links
Link Check ReportThere were no links to check! |
Checked then ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As stated before, I believe we shouldn't provide any Bitbucket GPU example code unless it works.
Approving with the expectation of seeing #362 (comment) addressed in a follow-up pull request.
opens #367 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are absolutely definitely not moving from iterative([.-]ai)?
to a new iterative-test
org on all git hosts. https://github.com/iterative/cml-examples-dev is using the *-test
orgs just for hacky dev purposes, they are not and will never be official.
And when we do migrate to better demo repo names, it'll be in a different PR as part of https://github.com/iterative/cml-examples-dev/issues/9
)} | ||
bitbucket={( | ||
<Collapser> | ||
<Code filename="bitbucket-pipelines.yml" repo="https://bitbucket.org/iterative-test/cml-example-cloud"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- TODO: @dacbd TPI example
<Code filename="bitbucket-pipelines.yml" repo="https://bitbucket.org/iterative-test/cml-example-cloud"> | |
<Code filename="bitbucket-pipelines.yml" repo="https://bitbucket.org/iterative-ai/cml-example-cloud-gpu"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite solid from a code standpoint. Nice work! I'd be totally fine merging this code (once the content is ready, of course!) and we can handle duplication later- theme-ui's days are numbered once iterative/gatsby-theme-iterative#33 is in and makes it way here, so that duplication issue will be solved then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now to unblock :)
Merging because I feel bored 🥱 |
...and forever [hold your peace] 😉 |
Right now is missing:
-
vs_
In review app: https://cml-dev-forge-bitbucket-x1ubcz.herokuapp.com/#use-cases