Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade PAT section #119

Merged
merged 6 commits into from
Oct 11, 2021
Merged

upgrade PAT section #119

merged 6 commits into from
Oct 11, 2021

Conversation

casperdcl
Copy link
Contributor

Patty McPatface

@casperdcl casperdcl added the documentation Markdown files label Oct 8, 2021
@casperdcl casperdcl self-assigned this Oct 8, 2021
@shcheklein shcheklein temporarily deployed to cml-dev-pats-9dg3ffn8cvoduvync October 8, 2021 21:20 Inactive
@casperdcl casperdcl requested a review from 0x2b3bfa0 October 8, 2021 21:20
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Oct 8, 2021 •
edited
Loading

Any reason to include a step–by–step guide for GitLab and Bitbucket but not for GitHub?

0x2b3bfa0
0x2b3bfa0 approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Optional desideratum: adjust the information level for all the platforms, either linking to external guides or providing internal guides for all of them.

@shcheklein shcheklein temporarily deployed to cml-dev-pats-9dg3ffn8cvoduvync October 11, 2021 11:52 Inactive
casperdcl
casperdcl commented Oct 11, 2021
View reviewed changes
Copy link
Contributor Author

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unified level of detail

content/docs/self-hosted-runners.md Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to cml-dev-pats-9dg3ffn8cvoduvync October 11, 2021 12:30 Inactive
@casperdcl casperdcl merged commit ab05bff into master Oct 11, 2021
@casperdcl casperdcl deleted the pats branch October 11, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@casperdcl casperdcl

Labels
documentation Markdown files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casperdcl @0x2b3bfa0 @shcheklein