Middleman #1
Open
Middleman #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteral
commented
Sep 28, 2017
| content: challengeContent | ||
| } | ||
| })).return([`http://${domain}/.well-known/acme-challenge/${key}`, value]); |
There was a problem hiding this comment.
@devico Why you change this line?
There was a problem hiding this comment.
эта часть пути указывает где gitlab-letsencrypt будет искать сгенерированный файл, так как у нас файл положен в папку source он должен быть доступен в корне сайта, поэтому эту часть пути я и удалил
There was a problem hiding this comment.
I think it should revert because letsencript.com use that path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.