Fixed email notifications when tariff was changed

[KizerovDmitriy]

Summary by CodeRabbit

• Bug Fixes
  • Refined the order filtering so that unpaid orders now exclude those with a canceled status, ensuring users see only valid unpaid orders.

[coderabbitai]

Walkthrough

The change updates the findAllUnpaidOrdersWithUsersByBagId method in the repository interface. The query condition now includes an additional check that excludes orders with a status of 'CANCELED'. This modification ensures that the method retrieves only unpaid orders that are still active, refining how order data is selected.

Changes

File	Summary
dao/.../OrderRepository.java	Updated the query in findAllUnpaidOrdersWithUsersByBagId to exclude orders with status 'CANCELED'.

Poem

In the code, a tweak so neat,
Where unpaid orders are now complete.
Canceled ones are set aside,
With logic clear and bona fide.
A repository refined—cheers to the feat!
🚀✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45eeccb and b7a2f76.

📒 Files selected for processing (1)

• dao/src/main/java/greencity/repository/OrderRepository.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (1)

dao/src/main/java/greencity/repository/OrderRepository.java (1)

178-182: LGTM! Well-structured query that aligns with business requirements.

The modification to exclude canceled orders is a good improvement that ensures email notifications for tariff changes are only sent for active unpaid orders. The query is well-structured with appropriate fetch joins to avoid N+1 queries.

Consider adding test coverage for the CANCELED order case.

To ensure the exclusion of canceled orders continues to work as expected, consider adding a test case that verifies:

1. A canceled unpaid order is not returned
2. An active unpaid order is returned

Would you like me to help generate the test cases?

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud