Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #4401 - Added Reasons of Bonus for change of user points. #1567

Merged

Conversation

ChernenkoVitaliy
Copy link
Contributor

GreenCityUBS PR

Issue Link 📋

#4401

Added

  • Created enum BonusReason with constants and short description for ua and en langs;
  • Added field reason(BonueReason) in ChangeOfPoints entity;
  • Created changelog ch-add-column-reason-into-change-of-points-table-Chernenko.xml for creating column reason in change_of_points table;
  • Added changelog link into db.changelog-master.xml;
  • Added reasonUa and reasonEn string fields into PointsForUbsUserDto;

Changed

  • Refactored and PointsForUbsUserDtoMapper;
  • Refactored PointsForUbsUserDtoMapperTest according to changes in PointsForUbsUserDtoMapper class;
  • Modified methods processRefundForBroughtItHimselfOrder, processRefundForDoneAndCanceledOrder, refundPaymentsInBonus(both), transferPointsToUser in PaymentServiceImpl for adding and saving reason for adding bonuses;
  • Modified method formAndSaveUser in UBSClientServiceImpl class for writing off bonus points;

Summary Of Changes 🔥

Added functionality for describing adding or writing off bonus points according to task #4401;

…and en langs;

Added field reason(BonueReason) in ChangeOfPoints entity;
Created changelog ch-add-column-reason-into-change-of-points-table-Chernenko.xml for creating column reason in change_of_points table;
Added changelog link into db.changelog-master.xml;
Added reasonUa and reasonEn string fields into PointsForUbsUserDto;
Refactored and PointsForUbsUserDtoMapper;
Refactored PointsForUbsUserDtoMapperTest according to changes in PointsForUbsUserDtoMapper class;
Modified methods processRefundForBroughtItHimselfOrder, processRefundForDoneAndCanceledOrder, refundPaymentsInBonus(both), transferPointsToUser in PaymentServiceImpl for adding and saving reason for adding bonuses;
Modified method formAndSaveUser in UBSClientServiceImpl class for writing off bonus points;
@ChernenkoVitaliy ChernenkoVitaliy self-assigned this Dec 19, 2024
@ChernenkoVitaliy ChernenkoVitaliy changed the title Feature #4401 - [Change request to #3670] <Reasons of Bonuse Feature #4401 - [Change request to #3670] <Reasons of Bonuse> Dec 19, 2024
@ChernenkoVitaliy ChernenkoVitaliy changed the title Feature #4401 - [Change request to #3670] <Reasons of Bonuse> Feature #4401 - Added Reasons of Bonus for change of user points. Dec 19, 2024
Copy link
Contributor

@LazarenkoDmytro LazarenkoDmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChernenkoVitaliy ChernenkoVitaliy merged commit 0093b1b into dev Dec 20, 2024
4 checks passed
@ChernenkoVitaliy ChernenkoVitaliy deleted the feature/4401/change-request-to-3670-reasons-of-bonuse branch December 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants