Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquibase redundante records #1558

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

holotsvan
Copy link
Collaborator

@holotsvan holotsvan commented Dec 16, 2024

dev

Issue

ita-social-projects/GreenCity#7947

Summary of issue

There are a lot of redendant changeLogs which are adding something, that this something is deleting and etc.

Summary of change

  • Using liquibase pro create changeLog on new initialized db (free version has limitations on entities which would be copied)
liquibase \
   --driver=org.postgresql.Driver \
   --url="jdbc:postgresql://localhost:5432/<db>" \
   --changeLogFile="db-changelog-full.xml" \
   --username=postgres \
   --password=<password>  \
   --logLevel=info  \ 
   --defaultSchemaName=public  \
   --diffTypes=catalogs,checkconstraints,columns,data,databasepackage,databasepackagebody,foreignkeys,functions,indexes,primarykeys,sequences,storedprocedures,tables,triggers,uniqueconstraints,views \
   --liquibaseProLicenseKey=<key> \
    generateChangeLog
  • Change tags with pro: to their alternatives from free version
  • add preconditions to each changeSet

Testing approach

  • Initialize new db using this changeLog
  • Run on old db with new changelog to see that everything runs fun

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link
Contributor

@LazarenkoDmytro LazarenkoDmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ita-social-projects ita-social-projects deleted a comment from coderabbitai bot Jan 6, 2025
@ita-social-projects ita-social-projects deleted a comment from coderabbitai bot Jan 6, 2025
@holotsvan
Copy link
Collaborator Author

@coderabbitai configuration

Copy link

coderabbitai bot commented Jan 7, 2025

CodeRabbit configuration
language: en-US
tone_instructions: ''
early_access: false
enable_free_tier: true
reviews:
  profile: chill
  request_changes_workflow: false
  high_level_summary: true
  high_level_summary_placeholder: '@coderabbitai summary'
  auto_title_placeholder: '@coderabbitai'
  auto_title_instructions: ''
  review_status: true
  commit_status: true
  collapse_walkthrough: false
  changed_files_summary: true
  sequence_diagrams: true
  assess_linked_issues: true
  related_issues: true
  related_prs: true
  suggested_labels: true
  auto_apply_labels: false
  suggested_reviewers: true
  poem: true
  labeling_instructions: []
  path_filters: []
  path_instructions: []
  abort_on_close: true
  auto_review:
    enabled: true
    auto_incremental_review: true
    ignore_title_keywords: []
    labels: []
    drafts: false
    base_branches: []
  tools:
    shellcheck:
      enabled: true
    ruff:
      enabled: true
    markdownlint:
      enabled: true
    github-checks:
      enabled: true
      timeout_ms: 90000
    languagetool:
      enabled: true
      enabled_only: false
      level: default
    biome:
      enabled: true
    hadolint:
      enabled: true
    swiftlint:
      enabled: true
    phpstan:
      enabled: true
      level: default
    golangci-lint:
      enabled: true
    yamllint:
      enabled: true
    gitleaks:
      enabled: true
    checkov:
      enabled: true
    detekt:
      enabled: true
    eslint:
      enabled: true
    rubocop:
      enabled: true
    buf:
      enabled: true
    regal:
      enabled: true
    actionlint:
      enabled: true
    pmd:
      enabled: true
    cppcheck:
      enabled: true
    semgrep:
      enabled: true
    circleci:
      enabled: true
chat:
  auto_reply: true
knowledge_base:
  opt_out: false
  learnings:
    scope: auto
  issues:
    scope: auto
  jira:
    project_keys: []
  linear:
    team_keys: []
  pull_requests:
    scope: auto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants