[Admin cabinet] Fix Position and PositionDTOs, Add tests to all Position DTOs #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospodaryk
requested review from
NKorzhik,
ABbondar,
airetOK,
juseti,
AlexPokatilov,
Andrii-Yezenitskyi,
RomanSulymka,
roman-k3i,
RomanKuts and
yourromchikkkkk
ospodaryk
removed request for
NKorzhik,
RomanSulymka,
ABbondar,
roman-k3i,
airetOK,
juseti,
RomanKuts,
yourromchikkkkk,
AlexPokatilov and
Andrii-Yezenitskyi
| import lombok.NoArgsConstructor; | ||
| import lombok.Setter; | ||
| import lombok.ToString; | ||
| import lombok.*; |
| @@ -25,7 +25,7 @@ public class PositionDtoWithTranslateMapper extends AbstractConverter<Position, | |||
| protected PositionWithTranslateDto convert(Position position) { | |||
| Map<String, String> nameTranslations = new HashMap<>(); | |||
| nameTranslations.put("ua", position.getName()); | |||
| nameTranslations.put("en", position.getNameEN()); | |||
| nameTranslations.put("en", position.getNameEn()); | |||
There was a problem hiding this comment.
please remove unused import import greencity.dto.position.PositionDto;
| @Builder | ||
| @EqualsAndHashCode | ||
| @ToString | ||
| @Data |
| @Builder | ||
| @ToString | ||
| @Data |
RomaMocherniuk
approved these changes
Jun 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Markiro1
approved these changes
Jun 23, 2023
ABbondar
approved these changes
Jun 23, 2023
BranetE
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Admin cabinet] Fix Position and PositionDTOs, Add tests to all Position DTOs
ita-social-projects/GreenCity#5976
Fixed nameEN to nameEn
Added tests to all Position DTOs: AddingPositionDt, PositionDto, PositionWithTranslateDto
Changed annotation to @DaTa