Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5520 change request to 2865286637064977289828992900 29013707542054173492 clarification order validation and order details #1077

Merged
merged 20 commits into from
Apr 8, 2023
Merged

5520 change request to 2865286637064977289828992900 29013707542054173492 clarification order validation and order details #1077

merged 20 commits into from
Apr 8, 2023

Conversation

BranetE
Copy link
Contributor

@BranetE BranetE commented Apr 5, 2023 •
edited
Loading

dev

JIRA

Code reviewers

Summary of change

Added new notification templates and platforms
Added new method to NotificationService
Changed UBSManagementServiceImpl

##Testing Approach

  • Log in as user
  • Make an order and don`t pay for it.
  • Log in as admin
  • Change order status to Brought by Himself
  • You should receive email about changing status

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

BranetE added 6 commits April 3, 2023 17:22
@BranetE
created email for "Brought by himself" status
e3f5695
@BranetE
Merge branch 'dev' into 5520-change-request-to-2865286637064977289828…
c16c66b 
…992900-29013707542054173492-clarification-order-validation-and-order-details

# Conflicts:
#	dao/src/main/resources/db/changelog/db.changelog-master.xml
@BranetE
created email for "Brought by himself" status
66d226f
@BranetE
Merge branch 'dev' into 5520-change-request-to-2865286637064977289828…
2cd444f 
…992900-29013707542054173492-clarification-order-validation-and-order-details

# Conflicts:
#	dao/src/main/java/greencity/enums/NotificationType.java
#	dao/src/main/resources/db/changelog/db.changelog-master.xml
@BranetE
Final
ed71284
@BranetE
Format
700a9d1
@BranetE BranetE linked an issue Apr 5, 2023 that may be closed by this pull request
[Change request to #2865,#2866,#3706,#4977,#2898,#2899,#2900, #2901,#3707,#5420,#5417#3492 ] Clarification Order validation and Order details ita-social-projects/GreenCity#5520
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.5% 86.5% Coverage
0.0% 0.0% Duplication

@BranetE BranetE merged commit d9a965d into dev Apr 8, 2023
@BranetE BranetE deleted the 5520-change-request-to-2865286637064977289828992900-29013707542054173492-clarification-order-validation-and-order-details branch April 8, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJJazl JJJazl JJJazl approved these changes

@sergoliarnik sergoliarnik sergoliarnik approved these changes

@KharchenkoV KharchenkoV KharchenkoV approved these changes

@ABbondar ABbondar Awaiting requested review from ABbondar

@juseti juseti Awaiting requested review from juseti

@MarkAndzh MarkAndzh Awaiting requested review from MarkAndzh

@MaksymGolik MaksymGolik Awaiting requested review from MaksymGolik

@Markiro1 Markiro1 Awaiting requested review from Markiro1

@LiliaMokhnatska LiliaMokhnatska Awaiting requested review from LiliaMokhnatska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@BranetE @KharchenkoV @sergoliarnik @JJJazl