Delete photo #628
Merged
Delete photo #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulkats
requested review from
JimHolman1199,
bohdan-vyshynskyi,
HryshkoAnton,
luchward,
mr-pavlenko,
romanovskyroma,
skrebetsnataliia and
vitaliipolitylo
skrebetsnataliia
approved these changes
Oct 27, 2020
mr-pavlenko
reviewed
Oct 27, 2020
| @@ -40,6 +40,11 @@ export class EditPhotoPopUpComponent implements OnInit { | |||
| this.matDialogRef.close(); | |||
| } | |||
|
|
|||
| public delitePhoto(): void { | |||
| this.editProfileService.deleProfilePhoto().subscribe( | |||
| () => this.closeEditPhoto()); | |||
There was a problem hiding this comment.
What happens in case of error?
luchward
approved these changes
Oct 28, 2020
JimHolman1199
approved these changes
Oct 28, 2020
| @@ -22,6 +22,9 @@ | |||
| accept=".jpg, .jpeg, .png" | |||
| (change)="onSelectPhoto($event)"> | |||
| </label> | |||
| <button type="button" | |||
There was a problem hiding this comment.
<button type="button" [disabled]="!youCan'tClickMe" .....
how about making the button disabled, if user already have a default photo ?)
HryshkoAnton
approved these changes
Oct 28, 2020
bohdan-vyshynskyi
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1530;
Added 'Delete photo' button at 'Edit profile page'.
)
Added notification when user want to delete photo.
Added spinner for "Save photo" and "Delete photo" buttons.
Delete button is disabled if user has a default photo
