Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/#6370 #2706

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Bugfix/#6370 #2706

merged 4 commits into from
Oct 2, 2023

Conversation

KKatiaa
Copy link
Contributor

@KKatiaa KKatiaa commented Sep 28, 2023

There are no indents from the right edge of the page #6351
The "About service" button does not work. UBS footer. #6345
When adding 'Add service', the number in the 'Basic cost' column is not displayed correctly #6370

@@ -288,11 +288,15 @@ export class AddNewHabitComponent implements OnInit {
this.friendsIdsList = this.userFriendsService.addedFriends?.map((friend) => friend.id);
const defailtItemsIds = this.standartShopList.filter((item) => item.selected === true).map((item) => item.id);
const habitAssignProperties: HabitAssignPropertiesDto = { defaultShoppingListItems: defailtItemsIds, duration: this.newDuration };
console.log(habitAssignProperties, defailtItemsIds, this.standartShopList, 'habitAssignProperties');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed all console.logs

this.habitAssignService
.assignCustomHabit(this.habitId, this.friendsIdsList, habitAssignProperties)
.pipe(take(1))
.subscribe(() => {
this.customShopList.length > 0 ? this.addCustomHabitItems() : this.afterHabitWasChanged('habitAdded');
if (this.customShopList.length > 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (this.customShopList.length)

@@ -92,6 +92,7 @@ export class HeaderComponent implements OnInit, OnDestroy {
this.imgAlt = this.isUBS ? 'Image ubs logo' : 'Image green city logo';
this.localeStorageService.setUbsRegistration(this.isUBS);
this.toggleHeader();
console.log(this.navLinks, 'navLinks');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

@@ -22,11 +22,16 @@ export class UbsFooterComponent {

constructor(private dialog: MatDialog) {}

ngOnInit() {
console.log(this.ubsNavLinks, 'ubsNavLinks');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@KKatiaa KKatiaa self-assigned this Oct 1, 2023
@hnativlyubomyr hnativlyubomyr merged commit 2035b85 into dev Oct 2, 2023
@hnativlyubomyr hnativlyubomyr deleted the bugfix/#6370 branch October 2, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants