Bugfix/#5533-added-services #2281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKatiaa
requested review from
katia9261,
AlexW8719,
atsa21,
NadiiaStoiko and
ruslan-teh
katia9261
requested changes
Mar 28, 2023
| @@ -10,6 +10,7 @@ import { Order } from '../models/ubs.model'; | |||
| import { UBSOrderFormService } from './ubs-order-form.service'; | |||
| import { OrderClientDto } from 'src/app/ubs/ubs-user/ubs-user-orders-list/models/OrderClientDto'; | |||
| import { ResponceOrderFondyModel } from '../../ubs-user/ubs-user-orders-list/models/ResponceOrderFondyModel'; | |||
| import { serializeNodes } from '@angular/compiler/src/i18n/digest'; | |||
There was a problem hiding this comment.
Where do we use this import?
| @@ -157,4 +158,12 @@ export class OrderService { | |||
| saveOrderData(): void { | |||
| this.localStorageService.setOrderWithoutPayment(true); | |||
| } | |||
|
|
|||
| saveServiceName(serviceName: string): void { | |||
There was a problem hiding this comment.
Where do we use these functions and is there any reason to redeclare them?
|
Kudos, SonarCloud Quality Gate passed! |
atsa21
reviewed
Mar 29, 2023
| @@ -128,6 +128,10 @@ export class UbsAdminTariffsAddServicePopUpComponent implements OnInit, OnDestro | |||
| this.loadingAnim = false; | |||
| } | |||
|
|
|||
| getControl(control: string) { | |||
| return this.addServiceForm.get(control); | |||
There was a problem hiding this comment.
Add type of function return :AbstractControl
atsa21
reviewed
Mar 29, 2023
| > | ||
| </textarea> | ||
| <div class="validation" *ngIf="getControl('description').invalid && getControl('description').touched"> | ||
| {{ 'ubs-tariffs-add-service.error_service_field_message' | translate }} |
There was a problem hiding this comment.
Use app-ubs-input-error for ubs error messages
For example we use it in UBSAddAddressPopUpComponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5533 Change request to US #4427, #4428 "Add a service "Сервіс" to the pricing card", "Edit a service "Сервіс" in the pricing card"
ita-social-projects/GreenCity#5533