replace second parameter of ratingCalculation() metod from type 'EcoN…

[Warded120]

Issue Link: #8070

Changes:

• now passing the second parameter as 'UserVO' instead of mapping from type 'Econews' to 'UserVO' in ratingCalculation() metod

Summary by CodeRabbit

• Bug Fixes

  • Improved consistency in user rating calculation method in EcoNews service by standardizing the reference to rating point names.

• New Features

  • Introduced a new utility class for rating point action constants, including identifiers for news creation and undoing actions.

[coderabbitai]

Walkthrough

The changes involve modifications in the EcoNewsServiceImpl class, specifically in the save, saveEcoNews, and delete methods. The way the ratingCalculation method is called has been updated, replacing string literals for rating point names with constants from the newly introduced RatingPointsNames class. This adjustment standardizes the references to rating point names while maintaining the overall control flow and logic of the methods.

Changes

File	Change Summary
service/src/main/java/greencity/service/EcoNewsServiceImpl.java	Updated ratingCalculation method calls to use constants from RatingPointsNames instead of string literals.
service/src/main/java/greencity/rating/constant/RatingPointsNames.java	Introduced new class RatingPointsNames with constants CREATE_NEWS and UNDO_CREATE_NEWS.

Poem

🌿 In the code where constants gleam,
Rating points now flow like a dream.
No more strings that twist and bend,
Clarity and order, our new best friend!
With each change, our code takes flight,
A journey of logic, pure delight! 🚀

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5a42bf and befcfd3.

📒 Files selected for processing (1)

• service/src/main/java/greencity/rating/constant/RatingPointsNames.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• service/src/main/java/greencity/rating/constant/RatingPointsNames.java

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

service/src/main/java/greencity/rating/constant/RatingPointsNames.java (1)

3-6: Good practice using constants, but could benefit from documentation and utility class best practices.

The introduction of constants to standardize rating point names is a good practice. Consider these enhancements:

1. Add class-level Javadoc explaining the purpose
2. Add documentation for each constant
3. Prevent instantiation since this is a utility class

Here's how you could improve it:

 package greencity.rating.constant;

+/**
+ * Contains constant names for rating points used in the application.
+ * These constants are used to standardize the identifiers for rating-related actions.
+ */
 public class RatingPointsNames {
+    private RatingPointsNames() {
+        throw new UnsupportedOperationException("Utility class should not be instantiated");
+    }
+
+    /** Rating points awarded for creating a news article */
     public static final String CREATE_NEWS = "CREATE_NEWS";
+
+    /** Rating points deducted when undoing news creation */
     public static final String UNDO_CREATE_NEWS = "UNDO_CREATE_NEWS";
 }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac85d4e and e5a42bf.

📒 Files selected for processing (2)

• service/src/main/java/greencity/rating/constant/RatingPointsNames.java (1 hunks)
• service/src/main/java/greencity/service/EcoNewsServiceImpl.java (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• service/src/main/java/greencity/service/EcoNewsServiceImpl.java

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud