Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IP_FAMILIES for integration tests #5571

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions prow/config/jobs/istio.io.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,12 @@ jobs:
env:
- name: DOCKER_IN_DOCKER_IPV6_ENABLED
value: "true"
# IP_FAMILY is to be replaced by IP_FAMILIES fully,
# temporarily retaining it until https://github.com/istio/istio/pull/54421 is merged.
- name: IP_FAMILY
value: "dual"
- name: IP_FAMILIES
value: "IPv4,IPv6"
regex: ^(go.mod$|tests/|pkg/test/|prow/|content/en/boilerplates/snips/|content/en/docs/.*(test\.sh|/snips\.sh)$)

- name: update-ref-docs-dry-run
Expand Down
16 changes: 16 additions & 0 deletions prow/config/jobs/istio.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,25 @@ jobs:
env:
- name: DOCKER_IN_DOCKER_IPV6_ENABLED
value: "true"
# IP_FAMILY is to be replaced by IP_FAMILIES fully,
# temporarily retaining it until https://github.com/istio/istio/pull/54421 is merged.
- name: IP_FAMILY
value: "ipv6"
- name: IP_FAMILIES
value: "IPv6"

- name: integ-ds
command: [entrypoint, prow/integ-suite-kind.sh, test.integration.kube.environment]
requirements: [kind]
env:
- name: DOCKER_IN_DOCKER_IPV6_ENABLED
value: "true"
# IP_FAMILY is to be replaced by IP_FAMILIES fully,
# temporarily retaining it until https://github.com/istio/istio/pull/54421 is merged.
- name: IP_FAMILY
value: "dual"
- name: IP_FAMILIES
value: "IPv4,IPv6"

- name: integ-basic
architectures: [arm64]
Expand Down Expand Up @@ -242,8 +250,12 @@ jobs:
value: " --istio.test.kube.helm.values=cni.ambient.ipv6=true --istio.test.ambient "
- name: DOCKER_IN_DOCKER_IPV6_ENABLED
value: "true"
# IP_FAMILY is to be replaced by IP_FAMILIES fully,
# temporarily retaining it until https://github.com/istio/istio/pull/54421 is merged.
- name: IP_FAMILY
value: "ipv6"
- name: IP_FAMILIES
value: "IPv6"
command:
- entrypoint
- prow/integ-suite-kind.sh
Expand All @@ -260,8 +272,12 @@ jobs:
value: " --istio.test.kube.helm.values=cni.ambient.ipv6=true --istio.test.ambient "
- name: DOCKER_IN_DOCKER_IPV6_ENABLED
value: "true"
# IP_FAMILY is to be replaced by IP_FAMILIES fully,
# temporarily retaining it until https://github.com/istio/istio/pull/54421 is merged.
- name: IP_FAMILY
value: "dual"
- name: IP_FAMILIES
value: "IPv4,IPv6"
command:
- entrypoint
- prow/integ-suite-kind.sh
Expand Down