Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Update the binary version to 1.4.4 #747

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Update the binary version to 1.4.4 #747

merged 2 commits into from
Jan 13, 2020

Conversation

elfinhe
Copy link
Member

@elfinhe elfinhe commented Jan 10, 2020 •
edited
Loading

Update the binary version to 1.4.4

$ mesh version
version.BuildInfo{Version:"1.4.4", GitRevision:"unknown", GolangVersion:"go1.13.4", BuildStatus:"unknown", GitTag:"unknown"}

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 10, 2020
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 10, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2020
@elfinhe
Copy link
Member Author

elfinhe commented Jan 10, 2020

/retest

@elfinhe elfinhe marked this pull request as ready for review January 10, 2020 18:31
@elfinhe elfinhe requested a review from a team January 10, 2020 18:31
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 10, 2020
howardjohn
howardjohn approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve but re-iterate my stance that this is the wrong way to handle versioning

@elfinhe
Copy link
Member Author

elfinhe commented Jan 10, 2020

I will approve but re-iterate my stance that this is the wrong way to handle versioning

@howardjohn Now the binary will also read version from BuildInfo, if there is one it will override the hardcoded one.

@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2020
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2020
@istio-testing istio-testing merged commit 5bd36b5 into istio:release-1.4 Jan 13, 2020
@rlenglet rlenglet mentioned this pull request Jan 17, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elfinhe @howardjohn @googlebot @istio-testing