This repository has been archived by the owner on Jan 16, 2022. It is now read-only.
Introduce new attribute connection.mtls #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiwzhang
reviewed
Feb 6, 2018
control/include/http/check_data.h
Outdated
| @@ -42,6 +42,9 @@ class CheckData { | |||
| // Get request HTTP headers | |||
| virtual std::map<std::string, std::string> GetRequestHeaders() const = 0; | |||
|
|
|||
| // Returns true if connection is mutual TLS enabled. | |||
| virtual bool IsMutualTlsEnabledConnection() const = 0; | |||
There was a problem hiding this comment.
Can we just use "IsMutualTLS"
control/include/http/report_data.h
Outdated
| @@ -29,6 +29,9 @@ class ReportData { | |||
| public: | |||
| virtual ~ReportData() {} | |||
|
|
|||
| // Get upstream tcp connection ip and port. | |||
| virtual bool GetDestinationIpPort(std::string* ip, int* port) const = 0; | |||
There was a problem hiding this comment.
please comment on the format of ip in bytes
|
Please take a look. Thanks. |
|
/test mixerclient-presubmit |
JimmyCYJ
force-pushed
the
add-attribute-mtls
branch
from
7ca20a1 to
6ff5cf3
Compare
qiwzhang
approved these changes
Feb 6, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiwzhang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
istio-merge-robot
pushed a commit
to istio/proxy
that referenced
this pull request
Feb 7, 2018
Automatic merge from submit-queue. Support Mixer filter to send connection.mtls attribute. **What this PR does / why we need it**: This is a followup PR which implements functions defined in PR #[425](istio/old_mixerclient_repo#425). This support Mixer client to send connection.mtls attribute in Check() and Report() calls. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Introduce new mixer attribute "connection.mtls" which indicates whether connection is mutual TLS enabled. Add virtual function bool IsMutualTlsEnabledConnection() into http/check_data.h and tcp/check_data.h, and call this function inside AttributesBuilder::ExtractCheckAttributes(). Add another virtual function bool GetDestinationIpPort(std::string* ip, int* port) to report destination IP and port from HTTP filter.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #426Special notes for your reviewer:
Release note: