Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

Send Mixer attribute "connection.mtls" in Check() and Report() calls. #426

Closed
JimmyCYJ opened this issue Feb 6, 2018 · 0 comments · Fixed by #425
Closed

Send Mixer attribute "connection.mtls" in Check() and Report() calls. #426

JimmyCYJ opened this issue Feb 6, 2018 · 0 comments · Fixed by #425
Assignees
@JimmyCYJ

Comments

@JimmyCYJ
Copy link
Member

JimmyCYJ commented Feb 6, 2018

Introduce a new Mixer attribute "connection.mtls", which indicates whether connection is mutual TLS enabled.
Send this attribute in both Check() and Report() calls.
This is to support monitoring mTLS connections per service.
@JimmyCYJ JimmyCYJ self-assigned this Feb 6, 2018
@JimmyCYJ JimmyCYJ mentioned this issue Feb 6, 2018
Merged
istio-merge-robot pushed a commit that referenced this issue Feb 7, 2018
@JimmyCYJ @istio-merge-robot
Introduce new attribute connection.mtls (#425)
5b09518 
Automatic merge from submit-queue.

Introduce new attribute connection.mtls

**What this PR does / why we need it**: Introduce new mixer attribute "connection.mtls" which indicates whether connection is mutual TLS enabled. Add virtual function bool IsMutualTlsEnabledConnection() into http/check_data.h and tcp/check_data.h, and call this function inside AttributesBuilder::ExtractCheckAttributes(). Add another virtual function bool GetDestinationIpPort(std::string* ip, int* port) to report destination IP and port from HTTP filter.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #426 

**Special notes for your reviewer**:

**Release note**:

```release-note
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JimmyCYJ JimmyCYJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce new attribute connection.mtls JimmyCYJ/mixerclient
1 participant
@JimmyCYJ