Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws eks setup #13858

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Aws eks setup #13858

merged 9 commits into from
Sep 12, 2023

Conversation

praseedasathaye
Copy link
Contributor

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Ambient
  • [ X] Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@praseedasathaye praseedasathaye requested a review from a team as a code owner September 12, 2023 19:17
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Sep 12, 2023
@istio-testing
Copy link
Contributor

Hi @praseedasathaye. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kfaseela
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 12, 2023
@ericvn
Copy link
Contributor

ericvn commented Sep 12, 2023

/cherry-pick release-1.19

@istio-testing
Copy link
Contributor

@ericvn: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing merged commit 6d6256f into istio:master Sep 12, 2023
@istio-testing
Copy link
Contributor

@ericvn: #13858 failed to apply on top of branch "release-1.19":

Applying: adding Amazon EKS with Istio setup to platform-setup page
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in content/en/docs/setup/platform-setup/amazon-eks/index.md
Auto-merging content/en/docs/setup/platform-setup/amazon-eks/index.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 adding Amazon EKS with Istio setup to platform-setup page
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Contributor

@ericvn: new issue created for failed cherrypick: #13859

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ericvn pushed a commit to ericvn/istio.io that referenced this pull request Sep 12, 2023
istio-testing pushed a commit that referenced this pull request Sep 13, 2023
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request Sep 13, 2023
@wilsonwu wilsonwu mentioned this pull request Sep 13, 2023
10 tasks
istio-testing pushed a commit that referenced this pull request Sep 13, 2023
istio-testing pushed a commit to istio-testing/istio.io that referenced this pull request Sep 13, 2023
istio-testing added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants