-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed numbering for installation steps in the tip #13778
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @archups. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original numbers are correct. All items should be labeled 1., and the will be automatically numbered,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@ericvn Yes, it works usually that way, but not within tip. Please check the rendered number on the doc site itself https://istio.io/latest/docs/setup/install/operator/. |
If numbering doesn't work, I'd maybe recommend just using |
Using |
I did try that locally, and it didn't seem to work for me. Also tried some indentation changes. |
What did it display? It should work. |
Using
|
Looking through other parts of the doc, I do see #) used, most notably it seems when we need to restart numbering at some number. And it seems to be around Looking at this particular page, I don't really see numbering used at all, except in this tip, so removing the numbering makes sense to me. Keeping a bullet (using |
@@ -77,7 +77,7 @@ You can alternatively deploy the operator using Helm: | |||
$ kubectl create namespace istio-operator | |||
{{< /text >}} | |||
|
|||
1. Install operator using Helm. | |||
2. Install operator using Helm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Install operator using Helm. | |
2) Install operator using Helm. |
@@ -75,7 +75,7 @@ $ istioctl operator init --watchedNamespaces=istio-namespace1,istio-namespace2 | |||
$ kubectl create namespace istio-operator | |||
{{< /text >}} | |||
|
|||
1. 使用 Helm 安装 Operator。 | |||
2. 使用 Helm 安装 Operator。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. 使用 Helm 安装 Operator。 | |
2) 使用 Helm 安装 Operator。 |
/cherry-pick release-1.19 |
@ericvn: new pull request created: #13850 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.