Bump gateway api version used in examples #13591
Conversation
istio-testing
added
the
size/S
| @@ -53,7 +53,7 @@ Follow these steps to get started with ambient: | |||
|
|
|||
| {{< text bash >}} | |||
| $ kubectl get crd gateways.gateway.networking.k8s.io &> /dev/null || \ | |||
| { kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v0.6.1" | kubectl apply -f -; } | |||
| { kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v0.7.1" | kubectl apply -f -; } | |||
There was a problem hiding this comment.
Why are these docs using a hard coded version, instead of the latest version like all the other Istio docs?
| { kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v0.7.1" | kubectl apply -f -; } | |
| { kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref={{< k8s_gateway_api_version >}}" | kubectl apply -f -; } |
There was a problem hiding this comment.
My guess is because we want to reference a particular semver release rather than the commit SHA that currently exists. I can create another arg (e.g. k8s_gateway_api_tag) if that would be better?
There was a problem hiding this comment.
Generally, we want to use the version of the Gateway API that is the same as the version that was used to build the Istio impl that we're running in the test environment. That's what {{< k8s_gateway_api_version >}} returns.
Unless I'm missing something I don't think it makes sense to not do that here.
cc @howardjohn
| @@ -471,5 +471,5 @@ $ kubectl delete -f @samples/sleep/notsleep.yaml@ | |||
| If you installed the Gateway API CRDs, remove them: | |||
|
|
|||
| {{< text bash >}} | |||
| $ kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v0.6.1" | kubectl delete -f - | |||
| $ kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v0.7.1" | kubectl delete -f - | |||
There was a problem hiding this comment.
| $ kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref=v0.7.1" | kubectl delete -f - | |
| $ kubectl kustomize "github.com/kubernetes-sigs/gateway-api/config/crd/experimental?ref={{< k8s_gateway_api_version >}}" | kubectl delete -f - |
|
I suspect that since we've moved to a release version in the master branch again we can revert the changes I made when it moved from release in #13313 by adding |
|
I did re-add the target to the |
|
We also need to get the gateway-api update in istio/istio for which I created a PR as well. Once that merges, we can update istio.io to point to it, along with my other change and we will see 0.7.1 again. |
|
Part of the equation is if we need some later commits from gateway-api for our istio repo. I see that John has a PR to pull in a later version which contains Frank's kubernetes-sigs/gateway-api#2183. |
|
In my istio PR it is noted that 0.7.1 is a downgrade of the gateway-api version that what is being used. Since preliminary.istio.io follows the main istio branch, we may use a commit off of HEAD, with the idea that we would be back to a normal gateway-api release for our releases. It seems that as such, we really want to stay on the current version, and likely will move up in the near future as there is an update pending in an istio PR. One thing that isn't automated with this is we won't automatically pick the commit up in our tests/docs since the make target was disabled (hard to get actual string needed when it's not just a release). I can look into doing that again. |
|
@ericvn @keithmattix So IIUC, the correct fix for the docs in this PR, is to change them to use |
Signed-off-by: Keith Mattix II <[email protected]>
Please provide a description for what this PR is for.
Bump gateway-api version in the examples to 0.7.1
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.