Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.0] Remove kube-rbac-proxy #577

Conversation

istio-testing
Copy link
Collaborator

This is an automated cherry-pick of #556

Replaces proxy with controller-runtime functionality. Fixes istio-ecosystem#502.

Signed-off-by: Daniel Grimm <[email protected]>
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 75.33%. Comparing base (54e2123) to head (1ee1c0f).
Report is 1 commits behind head on release-1.0.

Files with missing lines Patch % Lines
cmd/main.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.0     #577      +/-   ##
===============================================
- Coverage        75.41%   75.33%   -0.09%     
===============================================
  Files               40       40              
  Lines             2481     2497      +16     
===============================================
+ Hits              1871     1881      +10     
- Misses             518      527       +9     
+ Partials            92       89       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgn
Copy link
Collaborator

dgn commented Jan 22, 2025

/retest

@istio-testing istio-testing merged commit 74bbde3 into istio-ecosystem:release-1.0 Jan 22, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants