Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic channel prefix detection #574

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dgn
Copy link
Collaborator

@dgn dgn commented Jan 22, 2025

It causes problems as we usually don't work on branches with a release- prefix.

It causes problems as we usually don't work on branches with a
`release-` prefix.

Signed-off-by: Daniel Grimm <[email protected]>
@dgn dgn requested a review from a team as a code owner January 22, 2025 10:33
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.65%. Comparing base (33ae0fa) to head (45eb203).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   75.81%   75.65%   -0.17%     
==========================================
  Files          40       40              
  Lines        2481     2481              
==========================================
- Hits         1881     1877       -4     
- Misses        511      514       +3     
- Partials       89       90       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgn
Copy link
Collaborator Author

dgn commented Jan 22, 2025

/cherry-pick release-1.0

@istio-testing
Copy link
Collaborator

@dgn: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing merged commit 41a1cc8 into istio-ecosystem:main Jan 22, 2025
15 of 16 checks passed
@dgn dgn deleted the fix-channel-naming branch January 22, 2025 11:04
@istio-testing
Copy link
Collaborator

@dgn: new pull request created: #575

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Jan 22, 2025
* upstream/main:
  Remove automatic channel prefix detection (istio-ecosystem#574)
  Create IstioRevisionTag documentation (istio-ecosystem#511)

# Conflicts:
#	bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Jan 22, 2025
* upstream/main:
  Remove kube-rbac-proxy (istio-ecosystem#556)
  Remove automatic channel prefix detection (istio-ecosystem#574)
  Create IstioRevisionTag documentation (istio-ecosystem#511)

# Conflicts:
#	bundle/manifests/sail-operator-metrics-service_v1_service.yaml
#	bundle/manifests/sailoperator.clusterserviceversion.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants