-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove automatic channel prefix detection #574
Conversation
It causes problems as we usually don't work on branches with a `release-` prefix. Signed-off-by: Daniel Grimm <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 75.81% 75.65% -0.17%
==========================================
Files 40 40
Lines 2481 2481
==========================================
- Hits 1881 1877 -4
- Misses 511 514 +3
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-1.0 |
@dgn: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dgn: new pull request created: #575 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* upstream/main: Remove automatic channel prefix detection (istio-ecosystem#574) Create IstioRevisionTag documentation (istio-ecosystem#511) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
* upstream/main: Remove kube-rbac-proxy (istio-ecosystem#556) Remove automatic channel prefix detection (istio-ecosystem#574) Create IstioRevisionTag documentation (istio-ecosystem#511) # Conflicts: # bundle/manifests/sail-operator-metrics-service_v1_service.yaml # bundle/manifests/sailoperator.clusterserviceversion.yaml
It causes problems as we usually don't work on branches with a
release-
prefix.