Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support use of istio-injection label in RevisionBased deployments #86

Closed
Tracked by #498
dgn opened this issue Apr 26, 2024 · 1 comment
Closed
Tracked by #498

Support use of istio-injection label in RevisionBased deployments #86

dgn opened this issue Apr 26, 2024 · 1 comment
Assignees
@dgn
Milestone
v0.2

Comments

@dgn
Copy link
Collaborator

dgn commented Apr 26, 2024

Currently, we do not support the use of the istio-injection label when using the RevisionBased updateStrategy type. Instead, users have to use the istio.io/rev label to select workloads or namespaces for injection. We should make sure that the operator sets the default revision to the currently active revision so that the istio-injection label can be used.
@dgn dgn added this to the v0.1 milestone Apr 26, 2024
@dgn dgn mentioned this issue Apr 26, 2024
Open
@dgn dgn mentioned this issue Jun 18, 2024
Open
@dgn dgn self-assigned this Jun 27, 2024
dgn pushed a commit to dgn/sail-operator that referenced this issue Aug 15, 2024
@openshift-merge-bot
Merge pull request istio-ecosystem#86 from openshift-service-mesh-bot…
b591cbd 
…/none-main-merge_upstream_main-38a843ce

Automator: merge upstream changes to openshift-service-mesh/sail-operator@main
@dgn dgn modified the milestones: v0.1, v0.2 Aug 26, 2024
@dgn dgn mentioned this issue Nov 28, 2024
Closed
2 tasks
@dgn
Copy link
Collaborator Author

dgn commented Jan 17, 2025

This is now possible through the use of IstioRevisionTag.

@dgn dgn closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgn dgn

Labels
None yet
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@dgn