Skip to content

Commit

Permalink
[release-1.0] Use logAsJson instead of logAsJSON in ZTunnel APIs (#594)
Browse files Browse the repository at this point in the history
* Use logAsJson instead of logAsJSON in ZTunnel APIs

The Ztunnel charts (as well as other Istio resources) use
logAsJson and not logAsJSON.

Signed-off-by: Sridhar Gaddam <[email protected]>

* Instead of "nolint" use "logAsJSON" in the go struct

Signed-off-by: Sridhar Gaddam <[email protected]>

---------

Signed-off-by: Sridhar Gaddam <[email protected]>
Co-authored-by: Sridhar Gaddam <[email protected]>
  • Loading branch information
istio-testing and sridhargaddam authored Jan 28, 2025
1 parent c9d9284 commit 0100a32
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions api/v1/values_types_extra.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ type ZTunnelConfig struct {
// Same as `global.logging.level`, but will override it if set
Logging *GlobalLoggingConfig `json:"logging,omitempty"`
// Specifies whether istio components should output logs in json format by adding --log_as_json argument to each container.
LogAsJSON *bool `json:"logAsJSON,omitempty"`
LogAsJSON *bool `json:"logAsJson,omitempty"`
}

// ZTunnelGlobalConfig is a subset of the Global Configuration used in the Istio ztunnel chart.
Expand All @@ -118,7 +118,7 @@ type ZTunnelGlobalConfig struct { // Default k8s resources settings for all Isti
ImagePullSecrets []string `json:"imagePullSecrets,omitempty"`

// Specifies whether istio components should output logs in json format by adding --log_as_json argument to each container.
LogAsJSON *bool `json:"logAsJSON,omitempty"`
LogAsJSON *bool `json:"logAsJson,omitempty"`
// Specifies the global logging level settings for the Istio control plane components.
Logging *GlobalLoggingConfig `json:"logging,omitempty"`

Expand Down
4 changes: 2 additions & 2 deletions bundle/manifests/sailoperator.io_ztunnels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ spec:
items:
type: string
type: array
logAsJSON:
logAsJson:
description: Specifies whether istio components should output
logs in json format by adding --log_as_json argument to
each container.
Expand Down Expand Up @@ -262,7 +262,7 @@ spec:
description: Specifies the default namespace for the Istio
control plane components.
type: string
logAsJSON:
logAsJson:
description: Specifies whether istio components should output
logs in json format by adding --log_as_json argument to
each container.
Expand Down
4 changes: 2 additions & 2 deletions chart/crds/sailoperator.io_ztunnels.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ spec:
items:
type: string
type: array
logAsJSON:
logAsJson:
description: Specifies whether istio components should output
logs in json format by adding --log_as_json argument to
each container.
Expand Down Expand Up @@ -262,7 +262,7 @@ spec:
description: Specifies the default namespace for the Istio
control plane components.
type: string
logAsJSON:
logAsJson:
description: Specifies whether istio components should output
logs in json format by adding --log_as_json argument to
each container.
Expand Down

0 comments on commit 0100a32

Please sign in to comment.