clean up old code and update configwrite #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Tay <[email protected]>
rtay1188
commented
Feb 11, 2025
| @@ -244,7 +244,7 @@ func GetRootCmd(args []string) *cobra.Command { | |||
| rootCmd.PersistentFlags().BoolVar(¶ms.EnableSWAwareNSCaches, "enable_sw_aware_ns_caches", false, "Enable/Disable SW Aware NS Caches") | |||
| rootCmd.PersistentFlags().Int64Var(¶ms.DefaultWarmupDurationSecs, "default_warmup_duration_in_seconds", 45, "The default value for the warmupDurationSecs to be used on Destination Rules created by admiral") | |||
| rootCmd.PersistentFlags().BoolVar(¶ms.EnableGenerationCheck, "enable_generation_check", true, "Enable/Disable Generation Check") | |||
| rootCmd.PersistentFlags().BoolVar(¶ms.EnableIsOnlyReplicaCountChangedCheck, "enable_replica_count_check", true, "Enable/Disable Replica Count Check") | |||
There was a problem hiding this comment.
In previous PR I accidentally changed this to true, changing it back to false here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 76.95% 76.41% -0.55%
==========================================
Files 75 70 -5
Lines 10771 10736 -35
==========================================
- Hits 8289 8204 -85
- Misses 2057 2110 +53
+ Partials 425 422 -3 ☔ View full report in Codecov by Sentry. |
# Conflicts: # admiral/pkg/clusters/util.go
Punakshi
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up old state syncer code now that new code will be in the handlers rather than modifySE.
Also updating the configwriter - these will be removed later but leaving it in for now so that operator work can reference it.