Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESH-6000: ignore argo tracking tags during VS copy #375

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

rtay1188
Copy link
Collaborator

@rtay1188 rtay1188 commented Jan 7, 2025

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

Adds an ignore list for tags to be ignored during VS copy or other operations. Default is filled with argo tracking tags.

Ryan Tay added 2 commits January 7, 2025 15:48
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.78%. Comparing base (e885c76) to head (20274ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   76.76%   76.78%   +0.01%     
==========================================
  Files          75       75              
  Lines       10300    10307       +7     
==========================================
+ Hits         7907     7914       +7     
  Misses       1988     1988              
  Partials      405      405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	admiral/pkg/controller/common/config_test.go
Signed-off-by: Ryan Tay <[email protected]>
@rtay1188 rtay1188 merged commit b642331 into master Jan 8, 2025
3 checks passed
@rtay1188 rtay1188 deleted the MESH-6000-disallow-argo-labels branch January 8, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants