Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Drop flaky test #371

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

adilfulara
Copy link
Collaborator

Description

What does this change do and why?

  • Drop test that causes a race condition failure by go

Thank you!

- Drop test that causes a race condition failure by go

Signed-off-by: Adil Fulara <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.42%. Comparing base (ed49448) to head (11459eb).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   63.25%   71.42%   +8.17%     
==========================================
  Files          91       77      -14     
  Lines       12158    10360    -1798     
==========================================
- Hits         7690     7400     -290     
+ Misses       4053     2565    -1488     
+ Partials      415      395      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adilfulara adilfulara merged commit 2ed99fb into istio-ecosystem:master Jan 3, 2025
3 checks passed
@adilfulara adilfulara deleted the Regression-FlakyTest branch January 3, 2025 03:42
rtay1188 pushed a commit that referenced this pull request Feb 5, 2025
### Description
What does this change do and why?
- Drop test that causes a race condition failure by go

Thank you!

Signed-off-by: Adil Fulara <[email protected]>
Co-authored-by: Adil Fulara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants