Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating ingress DR for VS based routing #338

Merged

Conversation

shriramsharma
Copy link
Collaborator

Description

What does this change do and why?
Generates the DR which applied to the ingress in order to facilitate VS based cross cluster routing

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 65.11628% with 30 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (14b4735) to head (a01ece8).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
admiral/pkg/clusters/serviceentry.go 4.76% 20 Missing ⚠️
admiral/pkg/clusters/virtualservice_routing.go 90.16% 4 Missing and 2 partials ⚠️
admiral/pkg/controller/common/config.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
- Coverage   71.65%   71.59%   -0.07%     
==========================================
  Files          66       66              
  Lines        9212     9298      +86     
==========================================
+ Hits         6601     6657      +56     
- Misses       2253     2281      +28     
- Partials      358      360       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -16,6 +16,10 @@ import (
metaV1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

const (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shriramsharma shriramsharma merged commit 3f7eb67 into istio-ecosystem:master Sep 16, 2024
3 checks passed
@shriramsharma shriramsharma deleted the generate-ingress-dr branch September 16, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants