Handle weighted services #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2024 16:36
Signed-off-by: Ryan Tay <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 71.47% 71.49% +0.02%
==========================================
Files 65 65
Lines 8823 8845 +22
==========================================
+ Hits 6306 6324 +18
- Misses 2187 2191 +4
Partials 330 330 ☔ View full report in Codecov by Sentry. |
vinay-g
reviewed
Aug 21, 2024
| //TODO: Verify Local and Remote Endpoints are constructed correctly | ||
| identityConfigEnvironment *registry.IdentityConfigEnvironment) ([]*networkingV1Alpha3.WorkloadEntry, error) { | ||
| if len(identityConfigEnvironment.Services) == 0 { | ||
| return nil, fmt.Errorf("there were no services for the asset in namespace %s on cluster %s", identityConfigEnvironment.Namespace, serverCluster) |
There was a problem hiding this comment.
This is more common, maybe make this info
There was a problem hiding this comment.
Noted, will put this in next PR
vinay-g
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle weighted rollouts
Handle unweighted deployments and rollouts by sorting services and taking the first one