fixed the secret resolver intialization #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shriramsharma
force-pushed
the
fix_secret_resolver
branch
from
137df00 to
065aa5e
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 71.74% 71.74%
=======================================
Files 65 65
Lines 8723 8723
=======================================
Hits 6258 6258
Misses 2147 2147
Partials 318 318 ☔ View full report in Codecov by Sentry. |
vinay-g
reviewed
Aug 19, 2024
| log.Info("Initializing default secret resolver") | ||
| secretResolver, err = resolver.NewDefaultResolver() | ||
| } else { | ||
| err = fmt.Errorf("unrecognized secret resolver type %v specified", secretResolverType) | ||
| err = fmt.Errorf("unrecognized secret resolver type %v specified", admiralProfile) |
There was a problem hiding this comment.
err = fmt.Errorf("unrecognized admiral profile %v specified", admiralProfile)
Signed-off-by: Shriram Sharma <[email protected]>
Signed-off-by: Shriram Sharma <[email protected]>
Signed-off-by: Shriram Sharma <[email protected]>
shriramsharma
force-pushed
the
fix_secret_resolver
branch
from
e675eac to
3969712
Compare
vinay-g
approved these changes
Aug 19, 2024
kpharasi
approved these changes
Aug 19, 2024
|
Thanks @shriramsharma for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
What does this change do and why?
This fixed the default secret resolver intialization. It was broken during the merge.
[Link to related ISSUE]
Thank you!