Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shard status processing #325

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

rtay1188
Copy link
Collaborator

Shard handler now updates the shard status while producing networking resources from it.
Added tests for some of the shard status processing methods.

Ryan Tay added 2 commits August 16, 2024 12:40
Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.87719% with 56 lines in your changes missing coverage. Please review.

Project coverage is 71.48%. Comparing base (3e19061) to head (6d8cdea).
Report is 2 commits behind head on master.

Files Patch % Lines
admiral/pkg/clusters/shard_handler.go 50.44% 45 Missing and 11 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   71.74%   71.48%   -0.26%     
==========================================
  Files          65       65              
  Lines        8723     8821      +98     
==========================================
+ Hits         6258     6306      +48     
- Misses       2147     2186      +39     
- Partials      318      329      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

admiral/pkg/clusters/shard_handler.go Show resolved Hide resolved
admiral/pkg/clusters/shard_handler.go Show resolved Hide resolved
admiral/pkg/clusters/shard_handler.go Show resolved Hide resolved
admiral/pkg/clusters/shard_handler.go Outdated Show resolved Hide resolved
admiral/pkg/clusters/shard_handler.go Show resolved Hide resolved
Signed-off-by: Ryan Tay <[email protected]>
@rtay1188 rtay1188 merged commit ee2d3d0 into istio-ecosystem:master Aug 20, 2024
3 checks passed
@rtay1188 rtay1188 deleted the updateshard branch September 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants