Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shardcontroller enhancements #322

Merged
merged 10 commits into from
Aug 16, 2024
Merged

Conversation

rtay1188
Copy link
Collaborator

Add root parameter values and delete flow logging

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (0e8cee3) to head (afd5f8a).
Report is 8 commits behind head on master.

Files Patch % Lines
admiral/pkg/controller/common/config.go 0.00% 8 Missing ⚠️
admiral/pkg/controller/admiral/shard.go 28.57% 4 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
- Coverage   72.18%   72.08%   -0.11%     
==========================================
  Files          65       65              
  Lines        8730     8745      +15     
==========================================
+ Hits         6302     6304       +2     
- Misses       2118     2130      +12     
- Partials      310      311       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ryan Tay and others added 6 commits August 14, 2024 14:15
Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: kpharasi <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: kpharasi <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
Co-authored-by: Anubhav Aeron <[email protected]>
Co-authored-by: nirvanagit <[email protected]>

Adding operator functionality
- Add support for update event on NodeController

Signed-off-by: Adil Fulara <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
Ryan Tay added 2 commits August 15, 2024 15:05
Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
Signed-off-by: Ryan Tay <[email protected]>
@rtay1188 rtay1188 merged commit ac3fed9 into istio-ecosystem:master Aug 16, 2024
3 checks passed
@rtay1188 rtay1188 deleted the shardcontroller branch September 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants