Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add time metrics #320

Merged
merged 1 commit into from
Aug 16, 2024
Merged

add time metrics #320

merged 1 commit into from
Aug 16, 2024

Conversation

rtay1188
Copy link
Collaborator

Add timings

Add timings

Signed-off-by: Ryan Tay <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (c4d191c) to head (fc8a792).
Report is 7 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   72.18%   72.23%   +0.04%     
==========================================
  Files          65       65              
  Lines        8722     8737      +15     
==========================================
+ Hits         6296     6311      +15     
  Misses       2117     2117              
  Partials      309      309              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nirvanagit
Copy link
Collaborator

@rtay1188 - can we also expose the time using OTEL metrics?

@nirvanagit
Copy link
Collaborator

nirvanagit commented Aug 15, 2024

@rtay1188 - can we also expose the time using OTEL metrics?

As discussed, OTEL metrics will be added in subsequent PRs. Thanks @rtay1188 !

@rtay1188 rtay1188 merged commit e78eb2b into istio-ecosystem:master Aug 16, 2024
3 checks passed
@rtay1188 rtay1188 deleted the timing branch September 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants