Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MESH-5364] - Adding source cluster to VS copy list #315

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

vinay-g
Copy link
Collaborator

@vinay-g vinay-g commented Aug 13, 2024

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

This is a bug fix that copies the virtual service to source clusters as well, this is required to make sure local cluster clients can use this virtual service to communicate with the destination.

Thank you!

@vinay-g vinay-g marked this pull request as ready for review August 13, 2024 16:09
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (0e7d8fe) to head (c559cc1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   72.33%   72.42%   +0.09%     
==========================================
  Files          61       61              
  Lines        8349     8341       -8     
==========================================
+ Hits         6039     6041       +2     
+ Misses       2011     2003       -8     
+ Partials      299      297       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinay-g vinay-g merged commit 8207f91 into master Aug 13, 2024
3 checks passed
@vinay-g vinay-g deleted the MESH-5364-oss branch August 13, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants