Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added status check along with generation check #313

Conversation

shriramsharma
Copy link
Collaborator

@shriramsharma shriramsharma commented Aug 9, 2024

Checklist

🚨 Please review this repository's contribution guidelines.

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?
added status check along with generation check

Thank you!

@shriramsharma shriramsharma force-pushed the status-check-with-gen-check branch from 2a34f05 to c059ae1 Compare August 9, 2024 22:59
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.33%. Comparing base (6a100b3) to head (c059ae1).

Files Patch % Lines
admiral/pkg/controller/admiral/controller.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   72.35%   72.33%   -0.03%     
==========================================
  Files          61       61              
  Lines        8346     8349       +3     
==========================================
  Hits         6039     6039              
- Misses       2008     2011       +3     
  Partials      299      299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shriramsharma shriramsharma merged commit 0e7d8fe into istio-ecosystem:master Aug 9, 2024
3 checks passed
@shriramsharma shriramsharma deleted the status-check-with-gen-check branch August 9, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants