fix: Rollout canary when traffic routing not defined #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When canary.trafficRouting is not defined for Argo rollout canary strategy.
Expected:
The service match should return whichever service has a mesh port defined for creating service entry.
Found:
Admiral by default tries to match with the stable K8s service defined within rollout.stableService and if mesh port is not found in that K8s service, the Service Entry creation fails.
Fix:
When
canary.trafficRouting
is not defined for Argo rollout canary strategy. Scenario 1 from below should be expected.Overall Expected:
Scenario 1 - canary strategy defined and stable service is non empty
Pick stable service if present otherwise first service that matches
Scenario 2 - canary strategy defined with istio traffic management
Pick stable service/canary services defined in canary strategy
Senario 3 - No stable service is defined under canary strategy then pick a first matching service