Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process gtps as soon they are applied #223

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
made changes as per review comments
Signed-off-by: Shriram Sharma <[email protected]>
shriramsharma committed Jun 10, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit c8dbdbfc9baeb1c8ae081b50c10078294c34f1d5
8 changes: 4 additions & 4 deletions admiral/pkg/clusters/types.go
Original file line number Diff line number Diff line change
@@ -184,23 +184,23 @@ func (gtp *GlobalTrafficHandler) Added(obj *v1.GlobalTrafficPolicy) {
log.Infof(LogFormat, "Added", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "received")
err := HandleEventForGlobalTrafficPolicy(admiral.Add, obj, gtp.RemoteRegistry, gtp.ClusterID)
if err != nil {
log.Infof(LogFormat, "Event", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "Skipped as '"+common.GetWorkloadIdentifier()+" was not found', namespace="+obj.Namespace)
log.Infof(LogFormat, "Event", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "Skipped as "+err.Error()+", namespace = "+obj.Namespace)
}
}

func (gtp *GlobalTrafficHandler) Updated(obj *v1.GlobalTrafficPolicy) {
log.Infof(LogFormat, "Updated", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "received")
err := HandleEventForGlobalTrafficPolicy(admiral.Update, obj, gtp.RemoteRegistry, gtp.ClusterID)
if err != nil {
log.Infof(LogFormat, "Event", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "Skipped as '"+common.GetWorkloadIdentifier()+" was not found', namespace="+obj.Namespace)
log.Infof(LogFormat, "Event", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "Skipped as "+err.Error()+", namespace = "+obj.Namespace)
}
}

func (gtp *GlobalTrafficHandler) Deleted(obj *v1.GlobalTrafficPolicy) {
log.Infof(LogFormat, "Deleted", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "received")
err := HandleEventForGlobalTrafficPolicy(admiral.Delete, obj, gtp.RemoteRegistry, gtp.ClusterID)
if err != nil {
log.Infof(LogFormat, "Event", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "Skipped as '"+common.GetWorkloadIdentifier()+" was not found', namespace="+obj.Namespace)
log.Infof(LogFormat, "Event", "globaltrafficpolicy", obj.Name, gtp.ClusterID, "Skipped as "+err.Error()+", namespace="+obj.Namespace)
}
}

@@ -264,7 +264,7 @@ func HandleEventForGlobalTrafficPolicy(event admiral.EventType, gtp *v1.GlobalTr
globalIdentifier := common.GetGtpIdentity(gtp)

if len(globalIdentifier) == 0 {
return fmt.Errorf("missing %s on gtp named %s on cluster %s", common.GetWorkloadIdentifier(), gtp.Name, clusterName)
return fmt.Errorf(common.GetWorkloadIdentifier() + " was not found")
}

env := common.GetGtpEnv(gtp)