Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and comment in run.sh #110

Merged
merged 1 commit into from
May 28, 2020

Conversation

asushanthk
Copy link
Collaborator

No description provided.

@asushanthk asushanthk requested a review from aattuluri May 28, 2020 15:44
@aattuluri aattuluri merged commit 57eec64 into istio-ecosystem:master May 28, 2020
itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022
* Add Prometheus metric for number of clusters monitored (istio-ecosystem#208)

- Add cli flag to enable metrics collection via prometheus.
- Add endpoint to expose metrics in prometheus format when enabled and noop when disabled.
- Add gauge to capture clusters monitored metric.

* Prometheus Install in demo cluster (istio-ecosystem#209)

- Add kustomize template to install prometheus for scraping metrics
- Update admiral kustomize template for scraping by prometheus
- Add install script for prometheus
- Update CONTRIBUTING doc

Signed-off-by: Adil Fulara <[email protected]>

Co-authored-by: Adil Fulara <[email protected]>
Co-authored-by: Adil Fulara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants