MESH-000: Add detailed logging for client-initiated processing and gl… (

#364)

…obal traffic policy events (#830) (#831)

### Checklist
🚨 Please review this repository's [contribution
guidelines](./CONTRIBUTING.md).

- [ ] I've read and agree to the project's contribution guidelines.
- [ ] I'm requesting to **pull a topic/feature/bugfix branch**.
- [ ] I checked that my code additions will pass code linting checks and
unit tests.
- [ ] I updated unit and integration tests (if applicable).
- [ ] I'm ready to notify the team of this contribution.

### Description
What does this change do and why?

[Link to related ISSUE]

Thank you!

Co-authored-by: Punakshi Chaand <[email protected]>

admiral/pkg/clusters/deployment_handler.go

@@ -74,6 +74,7 @@ func HandleEventForDeployment(ctx context.Context, event admiral.EventType, obj
 	// Use the same function as added deployment function to update and put new service entry in place to replace old one
 	_, err := modifyServiceEntryForNewServiceOrPod(ctx, event, env, globalIdentifier, remoteRegistry)
 	if common.ClientInitiatedProcessingEnabled() {
+		log.Infof(LogFormat, event, common.DeploymentResourceType, obj.Name, clusterName, "Client initiated processing started for "+globalIdentifier)
 		depProcessErr := processClientDependencyRecord(ctx, remoteRegistry, globalIdentifier, clusterName, obj.Namespace)
 		if depProcessErr != nil {
 			return common.AppendError(err, depProcessErr)

admiral/pkg/clusters/rollout_handler.go

@@ -72,6 +72,7 @@ func HandleEventForRollout(ctx context.Context, event admiral.EventType, obj *ar
 	_, err := modifyServiceEntryForNewServiceOrPod(ctx, event, env, globalIdentifier, remoteRegistry)
 
 	if common.ClientInitiatedProcessingEnabled() {
+		log.Infof(LogFormat, event, common.DeploymentResourceType, obj.Name, clusterName, "Client initiated processing started for "+globalIdentifier)
 		rolloutProcessErr := processClientDependencyRecord(ctx, remoteRegistry, globalIdentifier, clusterName, obj.Namespace)
 		if rolloutProcessErr != nil {
 			return common.AppendError(err, rolloutProcessErr)

admiral/pkg/clusters/util.go

@@ -351,12 +351,15 @@ func processClientDependencyRecord(ctx context.Context, remoteRegistry *RemoteRe
 	var destinationsToBeProcessed []string
 
 	destinationsToBeProcessed = getDestinationsToBeProcessedForClientInitiatedProcessing(remoteRegistry, globalIdentifier, clusterName, clientNs, destinationsToBeProcessed)
-
+	log.Infof(LogFormat, "Update", common.DependencyResourceType, globalIdentifier, clusterName, fmt.Sprintf("destinationsToBeProcessed=%v", destinationsToBeProcessed))
 	var sourceClusterMap = common.NewMap()
 	sourceClusterMap.Put(clusterName, clusterName)
 
 	err := processDestinationsForSourceIdentity(ctx, remoteRegistry, "Update", true, sourceClusterMap, destinationsToBeProcessed, globalIdentifier, modifyServiceEntryForNewServiceOrPod)
-	return err
+	if err != nil {
+		return errors.New("failed to perform client initiated processing for " + globalIdentifier + ", got error: " + err.Error())
+	}
+	return nil
 }
 
 func getDestinationsToBeProcessedForClientInitiatedProcessing(remoteRegistry *RemoteRegistry, globalIdentifier string, clusterName string, clientNs string, destinationsToBeProcessed []string) []string {