-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strip .exe suffix via case-insensitive replacement (fixes #55 and #56) #57
Conversation
Strip a '.exe' extension via a case-insensitive replacement rather than via the case-sensitive 'ext` parameter to path.basename because it might be capitalized ('.EXE').
I'm not sure why three of the four Linux test runs failed. Each run seems to have failed a single test, but the test that failed is different in each case. Perhaps they're unrelated intermittent failures? I can't reproduce them locally, neither on Node 4.8.3 nor Node 6.11.0 (on my Ubuntu 16.04 system). I also can't reproduce on macOS. The Windows failures are presumably the unrelated ones from #55. |
I'm also faced the problem when I run coverage with nyc on Windows, see link below https://ci.appveyor.com/project/eggjs/egg-mock/build/1.0.377/job/cp0k4bjh54qd6l2t |
this PR will hotfix this code istanbuljs/spawn-wrap#57
this PR will hotfix this code istanbuljs/spawn-wrap#57
this PR will hotfix this code istanbuljs/spawn-wrap#57
@isaacs can you see this PR? |
Especially on Windows, where it might contain "Program Files".
Per <https://nodejs.org/api/process.html>, "Sending SIGINT, SIGTERM, and SIGKILL cause the unconditional termination of the target process." So Node ignores our SIGTERM handler, and the process ends when killed with that signal.
@isaacs dbf243a and bfd4bae fix the (unrelated) test failures on Windows that were reported in #55, so this now fixes both #55 and #56. The current failures are:
|
It looks like @isaacs decided to fix the issues himself instead of taking this pull request, so I'm closing it. |
Strip a '.exe' extension via a case-insensitive replacement rather than via the case-sensitive 'ext` parameter to path.basename because it might be capitalized ('.EXE'). This fixes #56 for me when testing https://github.com/mozilla/qbrt, which uses https://github.com/tapjs/node-tap, which uses https://github.com/istanbuljs/nyc, which uses this package.