Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Support for Blocked Pfaffian #26

Merged
merged 8 commits into from
Sep 23, 2021

Conversation

xrq-phys
Copy link
Collaborator

  • Added CMake support to blocked Pfaffian update.
  • NOTE: Unlike the traditional in-place mVMCconfig.sh which builds BLIS locally, the CMake strategy downloads a system-specific prebuilt artifact from xrq-phys/[email protected]+arm.
  • CMake option PFAFFIAN_BLOCKED is created. If the option is set to OFF, no blocked-Pfaffian would be built. No BLIS artifact would be downloaded, either.
  • Configs in /config set PFAFFIAN_BLOCKED to ON except for apple.cmake (due to GitHub CI unavailability) and gcc.cmake (since it's more or less system-agnostic and the auto-detection is not guaranteed to always work).

One more thing done in this PR: User is able to use the environment variable VMC_BLOCK_UPDATE_SIZE to override the default block size of Pfaffian update. As this does not affect computational results, I didn't add it to readdef.c.

@xrq-phys xrq-phys mentioned this pull request Sep 23, 2021
@tmisawa tmisawa merged commit 716b5e3 into issp-center-dev:develop Sep 23, 2021
@tmisawa
Copy link
Collaborator

tmisawa commented Sep 23, 2021

@xrq-phys
thank you for your great efforts!
I merged PR.

@tmisawa
Copy link
Collaborator

tmisawa commented Sep 24, 2021

@xrq-phys
I now checked and found that an error occurs in using cmake (not using PFAFFIAN_BLOCKED).

CMake Error at CMakeLists.txt:74 (add_subdirectory):
add_subdirectory given source "src/pfapack/fortran" which is not an
existing directory.

This may be caused by the incorrect link for pfapack.
Could you check the origin of this error?

@xrq-phys
Copy link
Collaborator Author

xrq-phys commented Sep 24, 2021 via email

@tmisawa
Copy link
Collaborator

tmisawa commented Sep 24, 2021

ok. Using git submodule update -r -i, cmake now works.
thank you!

@xrq-phys
Copy link
Collaborator Author

Btw with this CMake+prebuilt BLIS, Fugaku compilation no longer needs submitting compile.sh.

Cheers. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants