Skip to content

Commit

Permalink
Apply suggestions from code review: Filippe
Browse files Browse the repository at this point in the history
Co-authored-by: Filippe Spolti <[email protected]>
Signed-off-by: Edgar Hernández <[email protected]>
  • Loading branch information
israel-hdez and spolti committed Dec 16, 2024
1 parent 5288ca7 commit f25139a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion config/certmanager/certificate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ metadata:
name: serving-cert # this name should match the one appeared in kustomizeconfig.yaml
namespace: system
spec:
# SERVICE_NAME and SERVICE_NAMESPACE will be substituted by kustomize
# SERVICE_NAME and SERVICE_NAMESPACE will be replaced by kustomize
dnsNames:
- SERVICE_NAME.SERVICE_NAMESPACE.svc
- SERVICE_NAME.SERVICE_NAMESPACE.svc.cluster.local
Expand Down
2 changes: 1 addition & 1 deletion config/crd/kustomizeconfig.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This file is for teaching kustomize how to substitute name and namespace reference in CRD
# This file is for teaching kustomize how to replace name and namespace references in CRD
nameReference:
- kind: Service
version: v1
Expand Down

0 comments on commit f25139a

Please sign in to comment.