Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action #3

Merged
merged 12 commits into from
Jul 15, 2024
Merged

Add action #3

merged 12 commits into from
Jul 15, 2024

Conversation

nurmukhametov
Copy link
Collaborator

This PR contains a reworked version of the action from PR #1. There are two main differences: the use of actions/tool-cache and deriving default values for architecture/platform.

@ScatteredRay, thank you for your contribution. Your work was incredibly valuable and served as a solid foundation for this PR. It provided the necessary insights and direction, making the reworking process much smoother and more efficient.

This PR also includes a README.md derived from the draft version proposed by @maedoc.

Additionally, DEVELOPMENT.md and .gitignore were added to simplify the development process.

@nurmukhametov nurmukhametov requested a review from aneshlya July 12, 2024 14:34
Copy link
Contributor

@aneshlya aneshlya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a couple of minor style comments.

DEVELOPMENT.md Show resolved Hide resolved
README.md Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
src/main.js Show resolved Hide resolved
src/main.js Outdated Show resolved Hide resolved
It may happen that runner is banned by API rate limits. In this case,
just clone git repository and fetch the latest tag to define the latest
version.
Run npm run lint to check if src/main.js linted correctly.
Run npm run lint-fix to fix automatically.
Copy link
Contributor

@aneshlya aneshlya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aneshlya aneshlya merged commit 1ef003b into ispc:main Jul 15, 2024
9 checks passed
@aneshlya aneshlya linked an issue Oct 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Action for downloading ISPC in GH workflows
3 participants