-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action #3
Merged
Merged
Add action #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneshlya
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have a couple of minor style comments.
nurmukhametov
force-pushed
the
add-action
branch
from
July 12, 2024 18:44
5a19e31
to
22fa12b
Compare
aneshlya
reviewed
Jul 12, 2024
nurmukhametov
force-pushed
the
add-action
branch
from
July 15, 2024 12:01
22fa12b
to
fee4ed6
Compare
It may happen that runner is banned by API rate limits. In this case, just clone git repository and fetch the latest tag to define the latest version.
Run npm run lint to check if src/main.js linted correctly. Run npm run lint-fix to fix automatically.
nurmukhametov
force-pushed
the
add-action
branch
from
July 15, 2024 12:27
a604418
to
848047b
Compare
aneshlya
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a reworked version of the action from PR #1. There are two main differences: the use of
actions/tool-cache
and deriving default values forarchitecture
/platform
.@ScatteredRay, thank you for your contribution. Your work was incredibly valuable and served as a solid foundation for this PR. It provided the necessary insights and direction, making the reworking process much smoother and more efficient.
This PR also includes a
README.md
derived from the draft version proposed by @maedoc.Additionally,
DEVELOPMENT.md
and.gitignore
were added to simplify the development process.