refactor: use react-query for EditNavBar #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the `EditNavBar` component to use react-query to retrieve nav bar data from the backend. This includes moving the API call into a callback function defined in the api.js file.
By using react-query, we are also provided with the loading state of our api call - this means we don't need to handle it ourselves within our LoadingButton component. This commit introduces a simplified loading button which simply receives `isLoading` as a prop and renders a loading spinner and loading styles when `isLoading` is true.
kwajiehao
force-pushed
the
feat/display-collections-nav-bar
branch
from
b861d0a to
8672b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the
EditNavBarlayout to usereact-query, in line with our recent PRs (#350, #357). The GET and POST API calls are now defined as functions within theapi.jsfile, and we replace them withuseQueryanduseMutationin theEditNavBarcode.This PR also creates a new, simplified
LoadingButtoncomponent that is compatible withreact-query.react-queryprovides us with the loading state of our api call - this means we don't need to handle it ourselves within ourLoadingButtoncomponent. The new button component simply receives anisLoadingprop and renders a loading spinner and loading styles whenisLoadingis true.