fix: use menlo security for gsib #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // NOTE: Prepend the menlo link if this is on GSIB because | ||
| // GSIBs do a security scan that will fail otherwise with a TOO_MANY_REDIRECTS | ||
| // error when we access the raw link directly. | ||
| if (window.name.includes(GSIB_INDICATOR)) { |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 months ago
To fix the problem, we need to ensure that the check for GSIB_INDICATOR is done in a more secure manner. Instead of using a substring check, we should parse the URL and verify the host against a whitelist of allowed hosts. This will prevent any arbitrary hosts from being accepted.
- Parse the
window.nameto extract the host. - Check if the host is exactly
menlo-view.menlosecurity.comor any other allowed subdomains. - Update the code to use this more secure check.
Suggested changeset
1
src/hooks/useStagingLink.ts
| @@ -6,3 +6,5 @@ | ||
| // error when we access the raw link directly. | ||
| if (window.name.includes(GSIB_INDICATOR)) { | ||
| const url = new URL(window.name); | ||
| const allowedHosts = ['menlo-view.menlosecurity.com']; | ||
| if (allowedHosts.includes(url.host)) { | ||
| return `https://safe.menlosecurity.com/${link}` |
Copilot is powered by AI and may make mistakes. Always verify output.
seaerchin
force-pushed
the
fix/publish-button
branch
from
6d3525e to
4d0e1d0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
solution
menlosecurityand prepend if gsib is detected