fix(path-traversal): add regex to prevent path traversal attack #1828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, our frontend is vulnerable to path traversal attacks due to non-sanitisation of path parameters.
Solution
Validate site name according to teh regex in the picture below. sanitization is not done for other stuff like resource room name because these allow spaces in the name.
Attempting to use
%20
in the regex will lead to erroneous validation (as seen in the ss). We also cannot allow%
because this will lead to allowing url encoded characters (%5c
).