Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update manifest #1802

Merged
merged 3 commits into from
Feb 7, 2024
Merged

fix: update manifest #1802

merged 3 commits into from
Feb 7, 2024

Conversation

harishv7
Copy link
Contributor

@harishv7 harishv7 commented Feb 6, 2024 •
edited
Loading

Problem

Screenshot 2024-02-06 at 8 41 46 PM

Solution

Screenshot 2024-02-06 at 8 42 25 PM

@harishv7 harishv7 requested a review from a team February 6, 2024 12:36
shazlithebestie
shazlithebestie reviewed Feb 6, 2024
View reviewed changes
Copy link

@shazlithebestie shazlithebestie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harishv7 is the favicon referring to React's or Isomer's?

@harishv7
Copy link
Contributor Author

harishv7 commented Feb 6, 2024

@harishv7 is the favicon referring to React's or Isomer's?

@shazlithebestie fixed in latest commit

@dcshzj
Copy link
Contributor

dcshzj commented Feb 6, 2024

Is it possible to update this as well?

isomercms-frontend/public/index.html

Line 10 in 9ca1851

content="Web site created using create-react-app"

@harishv7
Copy link
Contributor Author

harishv7 commented Feb 6, 2024 •
edited
Loading

Is it possible to update this as well?

isomercms-frontend/public/index.html

Line 10 in 9ca1851

content="Web site created using create-react-app"

@dcshzj good catch, fixed + updated favicon

@harishv7 harishv7 merged commit 4c0f847 into develop Feb 7, 2024
8 checks passed
@harishv7 harishv7 deleted the update-manifest branch February 7, 2024 03:03
This was referenced Feb 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishore03109 kishore03109 kishore03109 approved these changes

@shazlithebestie shazlithebestie Awaiting requested review from shazlithebestie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harishv7 @dcshzj @kishore03109 @shazlithebestie